tools/qvm-run: translate negative return codes (signals) to positive exit codes#457
Open
EliasDevv wants to merge 1 commit intoQubesOS:mainfrom
Open
tools/qvm-run: translate negative return codes (signals) to positive exit codes#457EliasDevv wants to merge 1 commit intoQubesOS:mainfrom
EliasDevv wants to merge 1 commit intoQubesOS:mainfrom
Conversation
Author
|
I'm aware the commits are not GPG-signed yet. I'm setting up commit signing and will force-push signed commits shortly. |
Contributor
|
Please change the title of the commit message. "Translating return code" is what had to be done to accomplish the proposed goal. What this commit is about is exiting with the appropriate code. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When qvm-run is interrupted via SIGINT (ctrl-c), subprocess.wait()
returns a negative value (-signal). This translates negative return
codes to positive exit codes using abs(retcode) + 128, consistent
with shell signal handling conventions.
Fixes QubesOS/qubes-issues#10468